Changeset 6431


Ignore:
Timestamp:
06/01/10 13:25:35 (10 years ago)
Author:
bdezonia
Message:

Clarified TODOs at top of file

File:
1 edited

Legend:

Unmodified
Added
Removed
  • trunk/components/loci-plugins/test/loci/plugins/in/ImporterTest.java

    r6421 r6431  
    3333 
    3434// TODO 
    35 //    waiting on BF implementations for 
    36 //      range step by 0 or less 
    37 //      BF/imageJ returning wrong values of max num pixels (UINT32 off by one, float weird too, etc.) 
    38 //      memoryRecord failure needs BF code fix 
    39 //      comboCropAutoscale() - autoscale of a cropped image returning min of whole image 
    40 //      autoscale failing for Float and Double - need to decide on correct behavior in BF 
    41 //      autoscale of signed images an issue (INT16 gets clamped 0..65535 by ImageJ also) 
    42 //  - flesh out existing tests 
    43 //      write tests for the color options : some mention was made that indexcolor is an issue in testing 
    44 //        default 
    45 //        composite 
    46 //        colorized 
    47 //        grayscale 
    48 //        custom 
    49 //        autoscale - test written 
    50 //      open individual files: try to come up with a way to test without a disk file as source 
    51 //      swapped dims test needs to test cases other than from default swapping Z & T 
    52 //      output stack order - testing of iIndex? 
    53 //      range - uncomment the by 0 tests when BF fixed 
     35 
     36// must address before release 
     37//  - write tests for the color options : some mention was made that indexcolor is an issue in testing 
     38//     default - waiting on BF to know how it should behave 
     39//     composite 
     40//     colorized 
     41//     grayscale 
     42//     custom 
     43//     autoscale - test done but BF failing 
     44//  - comboCropAutoscale() - autoscale of a cropped image returning min of whole image 
     45//  - autoscale of signed images an issue (INT16 gets clamped 0..65535 by ImageJ also) 
    5446//  - add some tests for combination of options 
    55 //  - improve, comment, and generalize code for increased coverage 
     47//  - macros 
     48 
     49// would be nice to address before release 
     50 
     51//  waiting on BF implementations for 
     52//    - autoscale failing (when off?) for Float and Double - need to decide on correct behavior in BF 
     53//    - range step by 0 or less: uncomment these tests when BF fixed 
     54//    - BF/imageJ returning wrong values of max num pixels (UINT32 off by one, float weird too, etc.) 
     55//    - memoryRecord failure needs BF code fix 
     56//    - open individual files: try to come up with a way to test without a disk file as source 
     57//    - swapped dims test needs to test cases other than from default swapping Z & T 
     58//    - output stack order - testing of iIndex? should match isatck num, 5th plane == 5 
     59//    - improve, comment, and generalize code for increased coverage 
    5660 
    5761public class ImporterTest { 
     
    749753    ci.reset();  // force the channel processors to get initialized, otherwise nullptr  - TODO : does this point out a IJ bug? 
    750754     
     755    int maxZ = ci.getNSlices(); 
     756    int maxC = ci.getNChannels(); 
     757    int maxT = ci.getNFrames(); 
     758     
    751759    System.out.println("Checking index vals"); 
    752     System.out.println("maxes z c t = "+ci.getNSlices()+" "+ci.getNChannels()+" "+ci.getNFrames()); 
     760    System.out.println("maxes z c t = "+maxZ+" "+maxC+" "+maxT); 
     761     
    753762    // check that each image in the overall series has the correct iIndex value 
    754763    for (int z = 0; z < ci.getNSlices(); z++) 
     
    757766        { 
    758767          //getIndexPixelValue(ci,z,c,t,indexed); 
    759           assertEquals((6*t+3*z+c),getIndexPixelValue(ci,z,c,t,indexed)); 
     768          assertEquals((maxZ*maxC*t + maxC*z + c), getIndexPixelValue(ci,z,c,t,indexed));  // CZT order 
    760769        } 
    761770  } 
Note: See TracChangeset for help on using the changeset viewer.