Changeset 6473


Ignore:
Timestamp:
06/03/10 17:51:06 (9 years ago)
Author:
curtis
Message:

Clarify and expound on some TODOs.

Location:
trunk/components
Files:
4 edited

Legend:

Unmodified
Added
Removed
  • trunk/components/bio-formats/src/loci/formats/ChannelFiller.java

    r6448 r6473  
    158158    if (passthrough()) return reader.openBytes(no, buf, x, y, w, h); 
    159159 
     160    // TODO: The pixel type should change to match the available color table. 
     161    // That is, even if the indices are uint8, if the color table is 16-bit, 
     162    // The pixel type should change to uint16. Similarly, if the indices are 
     163    // uint16 but we are filling with an 8-bit color table, the pixel type 
     164    // should change to uint8. 
     165 
     166    // TODO: This logic below is opaque and could use some comments. 
     167 
    160168    byte[] pix = reader.openBytes(no, x, y, w, h); 
    161169    if (getPixelType() == FormatTools.UINT8) { 
  • trunk/components/bio-formats/src/loci/formats/CoreMetadata.java

    r6445 r6473  
    3737  // -- Fields -- 
    3838 
    39   // TODO 
    40   // 
    41   // We may want to consider refactoring the FormatReader getter methods 
     39  // TODO: We may want to consider refactoring the FormatReader getter methods 
    4240  // that populate missing CoreMetadata fields on the fly 
    4341  // (getChannelDimLengths, getChannelDimTypes, getThumbSizeX, getThumbSizeY) 
  • trunk/components/loci-plugins/src/loci/plugins/in/ImagePlusReader.java

    r6450 r6473  
    357357    return imps; 
    358358  } 
    359    
    360359 
    361360  private LUT[] makeLUTs(int series) { 
     
    366365    return luts; 
    367366  } 
    368    
     367 
    369368  private LUT makeLUT(int series, int channel) { 
    370369    final ImporterOptions options = process.getOptions(); 
     
    373372    return makeLUT(color); 
    374373  } 
    375    
     374 
    376375  private LUT makeLUT(Color color) { 
    377376    final int red = color.getRed(); 
     
    390389    return new LUT(r, g, b); 
    391390  } 
    392      
     391 
    393392  private FileInfo createFileInfo() { 
    394393    FileInfo fi = new FileInfo(); 
  • trunk/components/loci-plugins/src/loci/plugins/in/MainDialog.java

    r6466 r6473  
    102102    super(process); 
    103103  } 
    104    
     104 
    105105  // -- ImporterDialog methods -- 
    106106 
     
    109109    return !process.isWindowless(); 
    110110  } 
    111    
     111 
    112112  @Override 
    113113  protected GenericDialog constructDialog() { 
     
    136136    return gd; 
    137137  } 
    138    
     138 
    139139  @Override 
    140140  protected boolean harvestResults(GenericDialog gd) { 
     
    161161    return true; 
    162162  } 
    163    
     163 
    164164  // -- FocusListener methods -- 
    165165 
     
    256256    verifyOptions(null); 
    257257 
     258    // TODO: The info table and focus logic could be split into 
     259    // its own class, rather than being specific to this dialog. 
     260 
    258261    // associate information for each option 
    259262    infoTable = new HashMap<Component, String>(); 
     
    288291      // second column 
    289292      "10dlu, pref, " + 
    290             // third column 
     293      // third column 
    291294      "10dlu, fill:150dlu"; 
    292295 
     
    300303      "9dlu, pref, 3dlu, pref, 3dlu, pref, 3dlu, pref, 3dlu, pref"; 
    301304 
    302     // TODO: change "Use virtual stack" and "Record modifications to virtual 
     305    // TODO: Change "Use virtual stack" and "Record modifications to virtual 
    303306    // stack" checkboxes to "Stack type" choice with options: 
    304307    //   "Normal", "Virtual" or "Smart virtual" 
     
    526529    boolean splitEnabled = !isStackNone && !isStackBrowser && 
    527530      !isStackImage5D && !isStackView5D && !isVirtual; 
    528     // TODO: make splitting work with Data Browser & virtual stacks 
     531    // TODO: Make splitting work with Data Browser & virtual stacks. 
    529532 
    530533    // splitCBox 
Note: See TracChangeset for help on using the changeset viewer.