Ticket #466 (closed task: fixed)

Opened 10 years ago

Last modified 10 years ago

Review TIFF parsing logic

Reported by: melissa Owned by: melissa
Priority: critical Milestone: bio-formats-4.2
Component: bio-formats Severity: serious
Keywords: cleanup Cc:
Blocked By: Blocking:

Description

Need to ensure that everything in loci.formats.tiff:

  • Is thread-safe.
  • Takes advantage of recent I/O changes when possible (ticket #459).
  • Is properly documented.

Change History

comment:1 Changed 10 years ago by melissa

(In [5953]) Updated calls to TiffTools to use TiffParser instead, and removed TiffTools. See #466.

comment:2 Changed 10 years ago by melissa

(In [5956]) Removed some unnecessary TIFF parsing methods and cleaned up how BigTIFF data is detected and parsed. See #466.

comment:3 Changed 10 years ago by melissa

(In [5958]) * Altered IFD retrieval methods in TiffParser to be a little more intuitive, and updated readers accordingly. See #466.

  • Ported parts of r5880 to cleanup, so that TIFF detection works again.

comment:4 Changed 10 years ago by melissa

(In [5970]) Consolidated a lot of pixel unpacking logic. See #466.

comment:5 Changed 10 years ago by melissa

(In [5986]) Consolidated value offset/data length writing logic into a single helper method and made a few minor adjustments so that TiffSaver takes advantage of new TiffParser methods. See #466.

comment:6 Changed 10 years ago by melissa

(In [5988]) Removed null checking from IFD.getIFD*Value methods, as it was rarely used. See #466.

comment:7 Changed 10 years ago by melissa

(In [5990]) Updated differencing/undifferencing logic to be more generic. See #466.

comment:8 Changed 10 years ago by melissa

(In [6012]) Added basic TIFF pixels read/write tests. See #466.

comment:9 Changed 10 years ago by melissa

(In [6020]) Improved TiffSaver functionality and removed loci.formats.gui.AWTTiffTools. See #466.

comment:10 Changed 10 years ago by melissa

(In [6023]) Added a few more TiffSaver tests, and fixed bugs that prevented them from passing. See #466.

comment:11 Changed 10 years ago by melissa

  • Status changed from new to closed
  • Resolution set to fixed

comment:12 Changed 10 years ago by melissa

  • Milestone bio-formats-4.2 deleted

Milestone bio-formats-4.2 deleted

comment:13 Changed 10 years ago by melissa

  • Milestone set to bio-formats-4.2
Note: See TracTickets for help on using tickets.