Ticket #556 (closed defect: fixed)

Opened 9 years ago

Last modified 9 years ago

OME-TIFF reader should use MetadataOnly rather than BinData

Reported by: curtis Owned by: melissa
Priority: minor Milestone: bio-formats-4.2.1
Component: bio-formats Severity: serious
Keywords: Cc:
Blocked By: Blocking:

Description

When producing an output OME-XML block, the OME-TIFF reader should inject a MetadataOnly element rather than using a BinData with Length="0".

Change History

comment:1 Changed 9 years ago by melissa

(In [6978]) OMETiffReader now populates its' MetadataStore in such as way as to produce valid OME-XML (hopefully). BinData elements are not populated; instead, a MetadataOnly element is inserted under any Pixels that do not have at least one TiffData. See #556.

The only problem with this is that OMETiffReader.getMetadataStore() no longer returns a MetadataStore that can be used with an IFormatWriter (assuming, of course, that an IMetadata was passed to setMetadataStore). The current solution is a new OMETiffWriter API method: 'MetadataStore getMetadataStoreForConversion()'. This will return a MetadataStore of the same type as 'getMetadataStore()', but that contains the required BinData elements.

comment:2 Changed 9 years ago by melissa

  • Status changed from new to closed
  • Resolution set to fixed

I'm fairly certain that this was fixed in r6978, but feel free to re-open if r6978's behavior does not match the expected behavior.

comment:3 Changed 9 years ago by melissa

(In [7126]) Reversed usage of OMETiffReader's getMetadataStoreForDisplay() and getMetadataStoreForConversion(); getMetadataStore() is now equivalent to getMetadataStoreForConversion(). See #556.

Note: See TracTickets for help on using tickets.