Ticket #560 (closed defect: fixed)

Opened 9 years ago

Last modified 9 years ago

Fix multi-line description MetaMorph ND files

Reported by: callan Owned by: callan
Priority: minor Milestone:
Component: bio-formats Severity: minor
Keywords: Cc:
Blocked By: Blocking:

Description

When a MetaMorph ND file has a multi-line description setId() fails with an exception:

java.lang.StringIndexOutOfBoundsException: String index out of range: -3
	at java.lang.String.substring(String.java:1937)
	at loci.formats.in.MetamorphReader.initFile(MetamorphReader.java:286)
	at loci.formats.FormatReader.setId(FormatReader.java:901)
	at loci.formats.ImageReader.setId(ImageReader.java:588)
	at com.glencoesoftware.importer.queue.UploadReactor.upload(UploadReactor.java:458)
	at com.glencoesoftware.importer.queue.UploadReactor.run(UploadReactor.java:272)

Change History

comment:1 Changed 9 years ago by callan

(In [6922]) Merging r6367 from Trunk. (See #560)

comment:2 Changed 9 years ago by callan

  • Status changed from new to assigned

Original solution was made in Trunk with r6367. This solution does not handle multi-line descriptions "properly" it just ignores lines without a comma separating the keys and values of the ND file. We should probably move to a regular expression based parsing approach.

comment:3 Changed 9 years ago by callan

  • Priority changed from major to minor
  • Severity changed from serious to minor

comment:4 Changed 9 years ago by callan

(In [6923]) Fixing infinite loop introduced by merging r6367 from Trunk. (See #560)

comment:5 Changed 9 years ago by curtis

  • Status changed from new to closed
  • Resolution set to fixed

moved to  ome:#4153

Note: See TracTickets for help on using tickets.