Ticket #639 (closed task: fixed)

Opened 9 years ago

Last modified 9 years ago

Make sure that static fields are being used properly

Reported by: melissa Owned by: melissa
Priority: major Milestone: bio-formats-4.3
Component: bio-formats Severity: minor
Keywords: sprint-1 Cc: jmoore
Blocked By: Blocking:

Description

There are several static (non-final) HashMaps/Hashtables throughout the reader classes that could be made final.

The 'uuids' field in OMETiffWriter is static, but it is never cleared. If possible, it would be best to make this field non-static, or at least provide a mechanism for clearing stale entries to prevent memory leaks.

Similarly, the Location has several static fields (including 'idMap' and 'fileListings') for which it would be nice to have a master reset method that clears the HashMaps/Hashtables and resets associated fields to their original state.

Finally, we need to ensure that static fields are accessed in a thread-safe manner.

Change History

comment:1 Changed 9 years ago by melissa

  • Keywords sprint-1 added

comment:2 Changed 9 years ago by curtis

  • Status changed from new to closed
  • Resolution set to fixed

moved to  ome:#4183

Note: See TracTickets for help on using tickets.